1.9.1 release pending, please give it a look

[Will Cosgrove]

Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t already, give the main branch a sanity pass with your existing code and get any last minute issues submitted ASAP.

Thanks!

Will
_______________________________________________
libssh2-devel https:/

[Jan Ehrhardt]

Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021

We are pulling together the 1.9.1 release and I’d request, if you haven’t
already, give the main branch a sanity pass with your existing code and
get any last minute issues submitted ASAP.

Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
the main branch? That would be the easiest way to test
https://github.com/Frugghi/iSSH2 and
https://github.com/Jan-E/iSSH2/tree/catalyst

[Will Cosgrove]

Looks like they are! Otherwise, you can clone it from github (https://github.com/libssh2/libssh2 <https://github.com/libssh2/libssh2>) and build it.

Cheers,

Will

Post by Jan Ehrhardt
Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021

We are pulling together the 1.9.1 release and I’d request, if you haven’t
already, give the main branch a sanity pass with your existing code and
get any last minute issues submitted ASAP.

Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
the main branch? That would be the easiest way to test
https://github.com/Frugghi/iSSH2 and
https://github.com/Jan-E/iSSH2/tree/catalyst
--
Jan
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

[Jan Ehrhardt]

Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021

Post by Will Cosgrove
Looks like they are! Otherwise, you can clone it from github
(https://github.com/libssh2/libssh2 <https://github.com/libssh2/libssh2>)
and build it.

That was a bit hard, as neither the snapshots nor github contained
./configure. And the script at https://github.com/Frugghi/iSSH2 really
needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
installed.

In the end I took the configure from the LibSSH2 1.9.0 and got it
compiled. No problems encountered: my iPhone app uploaded 320 MB in 1:35m
from my home to a datacenter somewhere in Amsterdam via sftp.

[Dan Fandrich]

Post by Jan Ehrhardt
That was a bit hard, as neither the snapshots nor github contained
./configure. And the script at https://github.com/Frugghi/iSSH2 really
needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
installed.

The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

Dan
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo

[Jan Ehrhardt]

Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16

Post by Dan Fandrich

Post by Jan Ehrhardt
That was a bit hard, as neither the snapshots nor github contained
./configure. And the script at https://github.com/Frugghi/iSSH2 really
needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
installed.

The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

I know that autoreconf should do the trick. But autoreconf is not part of
the standard toolset on macOS with Xcode. I never needed it up until now.
See for instance https://superuser.com/a/897316/173319 for the extra steps
needed.

[Dan Fandrich]

Post by Jan Ehrhardt
Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16

Post by Dan Fandrich
The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

I know that autoreconf should do the trick. But autoreconf is not part of
the standard toolset on macOS with Xcode. I never needed it up until now.
See for instance https://superuser.com/a/897316/173319 for the extra steps
needed.

You're using an unreleased version of the source code for developers, so you'll
have to expect to use developer tools. If you use a released version, configure
will be included and you won't need to use these.

Dan
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi

[Jan Ehrhardt]

Dan Fandrich in gmane.network.ssh.libssh2.devel (Thu, 13 May 2021 00:18:21

Post by Dan Fandrich

Post by Jan Ehrhardt
Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16

Post by Dan Fandrich
The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

I know that autoreconf should do the trick. But autoreconf is not part of
the standard toolset on macOS with Xcode. I never needed it up until now.
See for instance https://superuser.com/a/897316/173319 for the extra steps
needed.

You're using an unreleased version of the source code for developers, so you'll
have to expect to use developer tools. If you use a released version, configure
will be included and you won't need to use these.

It was just a one time effort, as a reaction to Will's request for a
sanity pass.

[Will Cosgrove]

I do apprecate the efforts! In fact, I couldn’t run autoreconf with the configure.ac file as-is on my Mac (PR #594 if anyone is interested) so copying your old config file was fine for a quick test.

Cheers,
Will

Post by Jan Ehrhardt

Post by Dan Fandrich

Post by Jan Ehrhardt
Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16

Post by Dan Fandrich
The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

I know that autoreconf should do the trick. But autoreconf is not part of
the standard toolset on macOS with Xcode. I never needed it up until now.
See for instance https://superuser.com/a/897316/173319 for the extra steps
needed.

You're using an unreleased version of the source code for developers, so you'll
have to expect to use developer tools. If you use a released version, configure
will be included and you won't need to use these.

It was just a one time effort, as a reaction to Will's request for a
sanity pass.
--
Jan
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

_______________________________________________
libssh2-devel https://coo

[Daniel Stenberg]

Post by Jan Ehrhardt
Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
the main branch?

Yes they are!

[Daniel Stenberg]

We are pulling together the 1.9.1 release and I’d request, if you haven’t
already, give the main branch a sanity pass with your existing code and get
any last minute issues submitted ASAP.

There are a few changes and improvementslanded since 1.9.0 though, shouldn't
the next release from master than perhaps rather be called 1.10.0 ?

[Will Cosgrove]

Yup, sure. There are some features added so that makes sense. I’ll update the change logs PR to refer to 1.10.

Will

Post by Will Cosgrove
We are pulling together the 1.9.1 release and I’d request, if you haven’t already, give the main branch a sanity pass with your existing code and get any last minute issues submitted ASAP.

There are a few changes and improvementslanded since 1.9.0 though, shouldn't the next release from master than perhaps rather be called 1.10.0 ?
--
/ daniel.haxx.se_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libs

[Laurent Stacul]

Hello,

I am giving a try to libssh2 1.10.0. I tool the snapshot of 20210517
(https://libssh2.org/snapshots/libssh2-1.9.0-20210517.tar.gz).

Build with CMake is ok but running the tests fails:

+ ctest --output-on-failure
Test project /home/docker/development/opensource-pack-builder/components/ssh2/BUILD/libssh2-1.9.0-20210517/_build_shared
Start 1: test_hostkey
1/14 Test #1: test_hostkey ....................................................***Failed 0.21 sec
Error running command 'docker build -t libssh2/openssh_server openssh_server' (exit 256): Sending build context to Docker daemon 10.75kB
Step 1/32 : FROM debian:jessie
---> 3aaeab7a4777
Step 2/32 : RUN apt-get update && apt-get install -y openssh-server && apt-get clean && rm -rf /var/lib/apt/lists/*
---> Using cache
---> 396dccb5e4e3
Step 3/32 : RUN mkdir /var/run/sshd
---> Using cache
---> 08b0b21b084b
Step 4/32 : COPY ssh_host_rsa_key /tmp/etc/ssh/ssh_host_rsa_key
---> Using cache
---> 5ce3c9d315c9
Step 5/32 : RUN mv /tmp/etc/ssh/ssh_host_rsa_key /etc/ssh/ssh_host_rsa_key
---> Using cache
---> bae8bc7d29f0
Step 6/32 : RUN chmod 600 /etc/ssh/ssh_host_rsa_key
---> Using cache
---> 7597e217b7a9
Step 7/32 : COPY ssh_host_ecdsa_key /tmp/etc/ssh/ssh_host_ecdsa_key
COPY failed: file not found in build context or excluded by .dockerignore: stat ssh_host_ecdsa_key: file does not exist

Failed to build docker image

I think those distribution extra files are missing in the automake config.

Regards,
Stac

Post by Will Cosgrove
Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t already, give the main branch a sanity pass with your existing code and get any last minute issues submitted ASAP.
Thanks!
Will
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

_______________________________________________
libssh2-devel https:

[Laurent Stacul]

Hello,

In fact, there was still some missing file in the daily tarball
(https://libssh2.org/snapshots/libssh2-1.9.0-20210518.tar.gz). I
provided a PR to solve this
(https://github.com/libssh2/libssh2/pull/604).

I was also wondering if you would mind integrating the PRs I did to be
able to the the tests inside an OCI container:

- https://github.com/libssh2/libssh2/pull/557
- https://github.com/libssh2/libssh2/pull/560
- https://github.com/libssh2/libssh2/pull/559

As these PRs only touch tests (and more particularly the ones run when
using CMake), I don't think it would hurt.

Thanks in advance for your answers.
Regards,
Laurent

Post by Will Cosgrove
Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t already, give the main branch a sanity pass with your existing code and get any last minute issues submitted ASAP.
Thanks!
Will
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin

[Marc Hoersken]

Hello,

Post by Laurent Stacul
I was also wondering if you would mind integrating the PRs I did to be
- https://github.com/libssh2/libssh2/pull/557
- https://github.com/libssh2/libssh2/pull/560
- https://github.com/libssh2/libssh2/pull/559
As these PRs only touch tests (and more particularly the ones run when
using CMake), I don't think it would hurt.

I am currently working on making the tests work again on AppVeyor and
would like to merge your changes after that to see if they break
anything there.

This will hopefully happen during this week or on the weekend, but I am
not sure if this will be in time for the release.

Best regards,
Marc

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libs

[Marc Hoersken]

Post by Marc Hoersken
I am currently working on making the tests work again on AppVeyor and
would like to merge your changes after that to see if they break
anything there.

Good progress can be found here:
https://ci.appveyor.com/project/mback2k/libssh2/build/job/dtp4y5s7p8fk1cdm

The Docker container is now being run on GitHub Actions instead of
DigitalOcean, so we don't rely on someone paying that.

@alamaison did that for us in the past, but that changed some time ago.
Thanks again to him for doing that for a long time!

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listin

[Marc Hoersken]

Post by Marc Hoersken
https://ci.appveyor.com/project/mback2k/libssh2/build/job/dtp4y5s7p8fk1cdm
The Docker container is now being run on GitHub Actions instead of
DigitalOcean, so we don't rely on someone paying that.

Another update with the first completely successful run including tests
since September 2020:
https://ci.appveyor.com/project/mback2k/libssh2/builds/39247798

_______________________________________________
libssh2-devel https://co

[Laurent Stacul]

Hello,

The latest tarball (https://www.libssh2.org/snapshots/libssh2-1.9.0-20210519.tar.gz)
is working fine. Thanks for the quick merges.

Regards,
Laurent

Post by Will Cosgrove
Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t already, give the main branch a sanity pass with your existing code and get any last minute issues submitted ASAP.
Thanks!
Will
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-